New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: do not include advances for tds vouchers #43397

Open

ljain112 wants to merge 1 commit into frappe:develop from ljain112:fix-tds-advance

+3 −0

Contributor

ljain112 commented Sep 26, 2024

Issue: TDS is getting deducted even though the threshold has not been breached.

Steps To Replicate:

Create a Journal Entry for the supplier by debiting the supplier account and crediting tds account.
Now create a purchase invoice with apply_tds enabled and tds_category.
TDS will get deducted even though the threshold has not been breached.

Solution:
Only include vouchers with the same tax_withholding_category for checking if tds is deducted earlier.

Notes :

Since we are already checking for payment entry separately advances will be checked automatically.
Advances are still required for TCS(sales workflow) because tax_withholding_category field is not present in sales invoice.

Frappe Support Issue: https://support.frappe.io/helpdesk/tickets/17255


          fix: do not include advances for tds vouchers

7ef9184

ljain112 requested review from deepeshgarg007 and ruthra-kumar as code owners

September 26, 2024 14:42

github-actions bot added the needs-tests label

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels